This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
WebSockets RPC server #5425
Merged
WebSockets RPC server #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-inprogress ⏳
tomusdrw
added
A0-pleasereview 🤓
debris
approved these changes
Apr 8, 2017
There was a problem hiding this comment.
lgtm, just one side note
imo, with one of the next big releases, we should remove majority of cli options, including all of the above. They should be available only through configuration file. As an average user I don't care about ws sockets ports or anything like this. Our --help should be brief and fitting one screen. Now it's long and scares me away. As a user I would not bother reading it
gavofyork
added
A8-looksgood 🦄
tomusdrw
added
A3-inprogress ⏳
|
God, I'm sorry. I accidentally pushed new stuff I was working on to this branch. Will need to do merge again. |
tomusdrw
added
A0-pleasereview 🤓
|
Merge looks good |
maciejhirsz
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(no pub-sub yet, but it's coming)