Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Sparse Table Implementation (Row, Col) -> Val #545

Merged
merged 5 commits into from Mar 1, 2016
Merged

Sparse Table Implementation (Row, Col) -> Val #545

merged 5 commits into from Mar 1, 2016

Conversation

tomusdrw
Copy link
Collaborator

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Feb 29, 2016
}

/// Get mutable reference for single Table row.
pub fn get_row_mut(&mut self, row: &Row) -> Option<&mut HashMap<Col, Val>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is not to use get_ prefix in function names. Should be just row_mut

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 29, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Mar 1, 2016
NikVolf added a commit that referenced this pull request Mar 1, 2016
Sparse Table Implementation (Row, Col) -> Val
@NikVolf NikVolf merged commit be4cfa8 into master Mar 1, 2016
@tomusdrw tomusdrw deleted the table branch March 2, 2016 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants