This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Mining #547
Merged
Mining #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
gavofyork
added
A0-pleasereview 🤓
| @@ -403,8 +417,79 @@ impl Client { | |||
| BlockId::Latest => Some(self.chain.read().unwrap().best_block_number()) | |||
| } | |||
| } | |||
|
|
|||
| /// Set the author that we will seal blocks as. | |||
Reduce size of default extra-data. Introduce find_uncle_headers.
| } | ||
|
|
||
| /// Get the standard version data for this software. | ||
| pub fn version_data() -> Bytes { |
There was a problem hiding this comment.
given the output is based on environmental factors outside the control of the test environment, any test would simply be a copy'n'paste of the code in the function.
There was a problem hiding this comment.
still I believe we need one so that further possible modifications of this code are introduced with confidence
| } | ||
|
|
||
| /// Grab the `ClosedBlock` that we want to be sealed. Comes as a mutex that you have to lock. | ||
| pub fn sealing_block(&self) -> &Mutex<Option<ClosedBlock>> { |
NikVolf
added
A4-gotissues 💥
|
though it possibly works in this state, no tests actually prove this |
| &Ethash::to_ethash(header.mix_hash())))); | ||
| &Ethash::to_ethash(header.bare_hash()), | ||
| header.nonce().low_u64(), | ||
| &Ethash::to_ethash(header.mix_hash()) ))); |
|
will add tests for the
|
gavofyork
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
gavofyork
pushed a commit
that referenced
this pull request
Mar 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version_datafunction to misc to get the standard RLP version data.Clientclass; whenever the best block changes, or work is queried and noClosedBlockexists, a newClosedBlockis authored as a child of the best block. For 1.0 this somewhat monolithic design is ok; with Civility we will refactor this into a separate crate & process.ClosedBlockno longer retains anEnginereference;reopen()thus doesn't work in its old form - nothing was using it so removing is fine.seal()used theEnginereference. This is now supplied as a parameter. This allows us to hold onto aClosedBlockwithin theClientas the "currently sealing" block without having to worry about theEngine's lifetime.try_sealfunction toClosedBlockto check whether seal is any good (sealdoes something similar but doesn't check the seal).verify_block_sealto Engine.vofUnverifiedandPreverifiedto stay consistent with rest of codebase.U256<->U512conversions with pass-by-reference.Still todo:
TransactionQueuemerge).