This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Support external eth_sign #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
jacogr
reviewed
Apr 20, 2017
| @@ -85,7 +85,7 @@ export default class RequestOrigin extends Component { | |||
| <span> | |||
| <FormattedMessage | |||
| id='signer.requestOrigin.rpc' | |||
| defaultMessage='via RPC {rpc}' | |||
| defaultMessage='via RPC {url}' | |||
|
JS side LGTM. |
gavofyork
reviewed
Apr 25, 2017
| /// Parse bytes as a signature encoded as VRS (V in "Electrum" notation). | ||
| /// May return empty (invalid) signature if given data has invalid length. | ||
| pub fn from_vrs(data: &[u8]) -> Self { | ||
| if data.len() != 65 || data[0] < 27 { |
There was a problem hiding this comment.
probably want to ensure data[0] < 29, too.
There was a problem hiding this comment.
I'm not really trying to validate the signature yet (there is a separate function for this, see Signature#is_valid), the check is here to prevent panics/overflows.
gavofyork
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5469
Decrypt support is still to be done.