This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
BlockChain sync and Client app #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,7 +272,7 @@ impl BlockChain { | |||
| // create views onto rlp | |||
| let block = BlockView::new(bytes); | |||
| let header = block.header_view(); | |||
| let hash = block.sha3(); | |||
| let hash = header.sha3(); | |||
|
Please check the client interface in src/client.rs, changes in header.rs and everything else :) |
| for i in 13..d.len() { | ||
| blockheader.seal.push(try!(Decodable::decode(&d[i]))); | ||
| for i in 13..r.item_count() { | ||
| blockheader.seal.push(try!(r.val_at(i))) |
There was a problem hiding this comment.
this is now corrected in master (should be raw RLP, not the string value).
| @@ -104,3 +104,7 @@ pub mod genesis; | |||
| pub mod views; | |||
| pub mod blockchain; | |||
| pub mod extras; | |||
| pub mod client; | |||
There was a problem hiding this comment.
client module is missing ;)
file not found for module `client`
src/lib.rs:107 pub mod client;
|
|
||
| #[derive(PartialEq, Eq, Debug)] | ||
| enum PeerAsking | ||
| { |
There was a problem hiding this comment.
putting {s on newlines, now? :-)
|
All issues addressed |
| pub fn clear(&mut self) { | ||
| } | ||
|
|
||
| pub fn import_block(&mut self, bytes: &[u8]) -> ImportResult { |
| @@ -113,7 +113,7 @@ impl Spec { | |||
| let r = Rlp::new(&seal); | |||
| (0..self.seal_fields).map(|i| r.at(i).as_raw().to_vec()).collect() | |||
| }, | |||
| hash: RefCell::new(None), | |||
| hash: RefCell::new(None) | |||
There was a problem hiding this comment.
always leave trailing comma, no?
gavofyork
pushed a commit
that referenced
this pull request
Jan 11, 2016
BlockChain sync and Client app
niklasad1
pushed a commit
to niklasad1/parity
that referenced
this pull request
Mar 9, 2019
json-spec: fix clique epoch to non-zero u64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.