This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
reorg into blocks before minimum history #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
Although this isn't a problem during import because no pruning will occur until the block is fully enacted, "riding the edge" of the pruned states with RPC calls could lead to spurious failures and perhaps console warnings if the inspected state is pruned in the middle of the call, but will lead to no panics since we bubble up trie/db errors from |
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
May 18, 2017
arkpar
pushed a commit
that referenced
this pull request
May 18, 2017
arkpar
added a commit
that referenced
this pull request
May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using the dynamic
earliest_statecounter rather than the fixed minimum history size. Also does the same for RPCs and snapshot creation.Should backport to beta and perhaps stable if memory-based pruning is implemented there.