Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add a warning when node is syncing #5565

Merged
merged 4 commits into from May 10, 2017
Merged

Add a warning when node is syncing #5565

merged 4 commits into from May 10, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented May 5, 2017

Closes #5376

image

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels May 5, 2017
@jacogr
Copy link
Contributor

jacogr commented May 9, 2017

Looks very out of place - could we at least align it with the Connect dialog (closest I think to look & feel & placement)

@ngotchac
Copy link
Contributor Author

ngotchac commented May 9, 2017

You mean having the modal at the top?

<FormattedMessage
id='syncWarning.message.line2'
defaultMessage={ `
Some of the shown informations might be out-of-date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should just be "information"

@ngotchac
Copy link
Contributor Author

Updated

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 10, 2017
@jacogr jacogr merged commit 5baccaf into master May 10, 2017
@jacogr jacogr deleted the ng-sync-warning branch May 10, 2017 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants