This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
TransactionsQueue implementation #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,8 @@ use io::NetSyncIo; | |||
| mod chain; | |||
| mod io; | |||
| mod range_collection; | |||
| // TODO [todr] Made public to suppress dead code warnings | |||
| pub mod transaction_queue; | |||
There was a problem hiding this comment.
Will become private when it's integrated with EthSync
arkpar
added
A4-gotissues 💥
|
|
||
| //! Transaction Queue | ||
|
|
||
| use std::vec::Vec; |
There was a problem hiding this comment.
you don't need to import Vec, cause it's implicitly imported to every file.
added 5 commits
March 2, 2016 21:14
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
NikVolf
added a commit
that referenced
this pull request
Mar 4, 2016
TransactionsQueue implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionQueue should allow to:
If transaction's nonce matches
last known nonce+1it should be placed tocurrentqueue. (currentwill always contain contigous set of transactions from some sender e.g. (Sender(A), Nonce(1..3)))If transaction's nonce is greater then
expected+1it will be put tofuturequeue.Whenever nonces gap is introduced transactions are moved to
futureaccordingly. Whenever gap is filled transactions should be moved fromfutureback tocurrentBoth
futureandcurrentare kept in PriorityQueue sorted by relative nonce height (distance between transaction's nonce and first nonce incurrent(in case ofcurrent) or last nonce incurrent(in case offuture). If that height is equal transactions are sorted bygas priceand later bynonce(low nonces have more priority) andsender)