This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Create an account for chain=dev #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
I think this is really bad. There isn't a point in having a |
|
Yeah, I agree. Maybe I'm mistaken, but afaiu the code, secret-arithmetic may result in some invalid secrets, we can log it as a separate issue then. |
|
afaik, it can only result in invalid secrets if secp context is not initialized properly |
|
|
|
would be nice to have an option in the chain spec file that allows you to provide a secret rather than an account as a key to the genesis accounts section; in this case it would auto-create the account for you. but this is a good first effort in this direction. |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5335
Also contains #4414 - I've noticed that
Secretsemantics was changed anyway (it doesn't necessarily store a valid secret any more), so I've implemented convenient conversions and replaced occurrences in code.