This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix local transactions without condition. #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this looks good to me. Real shame that mistake. It's hard to check every use case sometimes. I wanted to test the branch myself, but I keep getting errors even using the branches rust compiled. Which branch of rust are you using to make the --ui-no-valdiation work? |
|
@CraigglesO No worries, we didn't catch it during the review either, and it wasn't that obvious that this functionality is actually required. |
jacogr
added
A8-looksgood 🦄
Merged
arkpar
pushed a commit
that referenced
this pull request
Jun 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to cancel transaction that didn't have a condition.
In fact no transaction was displayed, cause
TxRowexpected every transaction to always have a condition.Closes #5715