This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
three small commits for HashDB and MemoryDB #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guanqun
commented
Jun 5, 2017
guanqun
commented
- add one test case for consolidate in memorydb
- add a bit clarification to HashDB's remove() interface
- move MemoryDB's tests into its own tests module, more rusty...
rphmeier
added
A4-awaitingci 🤖
|
LGTM, thanks |
|
lgtm |
|
hey @guanqun, could you push again to trigger CI? Then I'll be glad to merge it. |
|
Rebased on top of current master and the CI checks look good. |
rphmeier
added
A8-looksgood 🦄
|
Thank you @rphmeier |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.