This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Duration limit made optional for EthashParams #5777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grbIzl
added
A0-pleasereview 🤓
rphmeier
added
A4-clasignoffneeded 📛
|
@rphmeier it's Anton Gavrilov, no CLA needed |
NikVolf
added
A0-pleasereview 🤓
|
ah, sorry Anton :) |
arkpar
reviewed
Jun 7, 2017
json/src/spec/ethash.rs
Outdated
| @@ -39,7 +39,7 @@ pub struct EthashParams { | |||
| pub metropolis_difficulty_increment_divisor: Option<Uint>, | |||
| /// See main EthashParams docs. | |||
| #[serde(rename="durationLimit")] | |||
| pub duration_limit: Uint, | |||
| pub duration_limit:Option<Uint>, | |||
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4401 Making duration limit parameter optional as it's not used in case of homestead transition. I didn't force any additional checks in tests. Just modify them in order to reflect the change.