This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Block invalid account name creation #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Jun 7, 2017
jacogr
commented
- Sets name error properly on empty name between next/prev
- Fixes clicking rapidly on next that creates invalid accounts in case where name was previously set
- Fixed token balance checks (currently Geth key imports are not working)
- Additional safety checks for empty phrase (fromNew) and canCreate in actual action handler
jacogr
added
A0-pleasereview 🤓
tomusdrw
reviewed
Jun 7, 2017
js/src/modals/CreateAccount/store.js
Outdated
| @@ -91,7 +91,11 @@ export default class Store { | |||
| } | |||
|
|
|||
| @computed get hasAddress () { | |||
| return !!(this.address); | |||
| return this.address.length !== 0; | |||
There was a problem hiding this comment.
this.address is never null/undefined?
There was a problem hiding this comment.
You are right, will revert - extra safety. (It should be empty, but no need to muck about)
| @@ -329,8 +329,6 @@ class CreateAccount extends Component { | |||
| } | |||
|
|
|||
| onCreate = () => { | |||
| this.createStore.setBusy(true); | |||
There was a problem hiding this comment.
Seems that we don't need to setBusy(false) as well (since it's done inside createAccount in store)
tomusdrw
added
A6-mustntgrumble 💦
jacogr
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Jun 7, 2017
tomusdrw
added
A8-looksgood 🦄
Merged
arkpar
pushed a commit
that referenced
this pull request
Jun 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.