Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

JSON-RPC personal service (follows #582) #583

Merged
merged 6 commits into from Mar 4, 2016
Merged

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Mar 4, 2016

No description provided.

@NikVolf NikVolf added the A0-pleasereview 🤓 Pull request needs code review. label Mar 4, 2016
pub struct PersonalClient {
secret_store: Weak<SecretStore>,
unlocked_account: Arc<RwLock<Option<Address>>>,
unlocked_secret: Arc<RwLock<Option<Bytes>>>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't secret always H256?

@debris
Copy link
Collaborator

debris commented Mar 4, 2016

I see that currently it's possible to unlock only 1 account at the same time. Is it the same in geth?

@debris debris added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 4, 2016
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Mar 4, 2016
@NikVolf
Copy link
Contributor Author

NikVolf commented Mar 4, 2016

moved logics to store
now can unlock multiple accounts as in geth

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 4, 2016
NikVolf added a commit that referenced this pull request Mar 4, 2016
JSON-RPC personal service (follows #582)
@NikVolf NikVolf merged commit a8f8195 into master Mar 4, 2016
@NikVolf NikVolf deleted the json-rpc-personal branch March 4, 2016 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants