This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Transaction Queue integration #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 1, 2016 22:30
Conflicts: sync/src/transaction_queue.rs
…id race conditions
Conflicts: ethcore/src/client.rs sync/src/tests/helpers.rs
|
Guessing rather than "bad", you mean retracted. |
| fn fetch_transactions(chain: &BlockChainClient, hash: &H256) -> Vec<SignedTransaction> { | ||
| let block = chain | ||
| .block(BlockId::Hash(hash.clone())) | ||
| .expect("Expected in-chain blocks."); |
There was a problem hiding this comment.
should include a short comment as to why, by design, this can never fail.
gavofyork
added
A8-looksgood 🦄
|
looks fine in general. will probably need moving to ethcore prior to being of use though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2&3 from #584 .
On good block we remove transactions from TransactionQueue.
For each "bad" block we insert transactions back to TransactionQueue.
Tests are modified to support blocks with transactions.
Most significant change: Changing order of block insertion: first we commit db and after that we insert block to blockchain (To avoid race when asking for state)