This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Filter tokens logs from current block, not genesis #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jul 24, 2017
| .then(() => newFilters) | ||
| Promise | ||
| .all([ | ||
| api.eth.blockNumber() |
There was a problem hiding this comment.
Do we need to retrieve the blockNumber again when we are already triggering this because of a blockNumber update?
There was a problem hiding this comment.
So this doesn't get triggered on new block, only when the filters need to be updated, which is when you need to update the tokens value of the displayed addresses, ie. when switching views between your account, your address book, contracts, etc. We don't update the tokens balances for accounts we don't show, except those we own (so we can get a notification)
jacogr
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Jul 25, 2017
* Filter tokens logs from current block, not genesis * Fix linting
arkpar
added a commit
that referenced
this pull request
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note that filters are only used to trigger a balance update and notifications)