Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Whisper js #6161

Merged
merged 10 commits into from Jul 31, 2017
Merged

Whisper js #6161

merged 10 commits into from Jul 31, 2017

Conversation

kaikun213
Copy link
Contributor

Shh api.
Subscriptions are missing.(method not found -> rpc)

@kaikun213 kaikun213 added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Jul 27, 2017
@parity-cla-bot
Copy link

It looks like @kaikun213 hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@kaikun213
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @kaikun213 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@rphmeier
Copy link
Contributor

Subscriptions should be fixed upon #6162

@kaikun213 kaikun213 requested a review from jacogr July 27, 2017 14:32
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A8-looksgood 🦄 Pull request is reviewed well. labels Jul 27, 2017
@jacogr
Copy link
Contributor

jacogr commented Jul 27, 2017

We need the functions added to jsonrpc as well. (docs)

@rphmeier
Copy link
Contributor

@jacogr https://github.com/paritytech/parity/wiki/JSONRPC-shh-Module

@kaikun213 kaikun213 added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jul 28, 2017
@jacogr jacogr added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 28, 2017
@jacogr
Copy link
Contributor

jacogr commented Jul 28, 2017

CI not passing.

@kaikun213 kaikun213 merged commit 9c5ef1f into master Jul 31, 2017
@ngotchac ngotchac deleted the whisper-js branch August 16, 2017 15:51
@jam10o-new jam10o-new mentioned this pull request Sep 30, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaikun213 @parity-cla-bot @rphmeier @jacogr