This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix dapps CSP when UI is exposed externally #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
|
I wonder if this also fixes the issues with DApps that I had on the light client where the page was completely blank. |
maciejhirsz
reviewed
Jul 28, 2017
| Some(hosts) => extra_embed.extend(hosts.into_iter().filter_map(|host| { | ||
| let mut it = host.split(":"); | ||
| let host = it.next(); | ||
| let port = it.next().and_then(|v| u16::from_str(v).ok()); |
There was a problem hiding this comment.
I guess we don't really care if the settings are invalid? (more than one colon, port not being valid uint?)
There was a problem hiding this comment.
Yeah, we always attempt to parse hosts/origins in the best way we can.
gavofyork
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Aug 18, 2017
* Allow embeding on any page when ui-hosts=all and fix dev_ui * Fix tests.
arkpar
added a commit
that referenced
this pull request
Aug 19, 2017
* overflow check in addition * add test * Unexpose methods on UI RPC. (#6295) * Add more descriptive error when signing/decrypting using hw wallet. * format instant change proofs correctly * propagate stratum submit share error upstream, fixes #6258 (#6260) * updated jsonrpc (#6264) * Using multiple NTP servers (#6173) * Small improvements to time estimation. * Allow multiple NTP servers to be used. * Removing boxing. * Be nice. * Be nicer. * Update list of servers and add reference. * Fix dapps CSP when UI is exposed externally (#6178) * Allow embeding on any page when ui-hosts=all and fix dev_ui * Fix tests. * Fix cache path when using --base-path (#6212) * Time should not contribue to overall status. (#6276) * v1.7.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6174
Also contains a fix to dapps development using latest inject.js, cc @kaikun213