Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Decouple virtual machines #6184

Merged
merged 7 commits into from Aug 1, 2017
Merged

Decouple virtual machines #6184

merged 7 commits into from Aug 1, 2017

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jul 28, 2017 •
edited

  • Now there is a common crate vm (/ethcore/vm)
  • EVM-specific code in evm crate (/ethcore/evm)
  • WASM-specific code in wasm crate (/ethcore/wasm)
  • A lot of code now does not use evm at all, depends only on vm (can be further factored out)

No new logic here, just a lot of tree changes

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 28, 2017
@NikVolf NikVolf changed the title Split virtual machines Decouple virtual machines Jul 28, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 31, 2017
@NikVolf NikVolf merged commit b700603 into master Aug 1, 2017
@NikVolf NikVolf deleted the split-vms branch August 1, 2017 10:38
@debris
Copy link
Collaborator

debris commented Aug 1, 2017 •
edited

@NikVolf wasm, evm and vm tests are broken

@debris
Copy link
Collaborator

debris commented Aug 1, 2017

they are not run by our CI, I fixed that in #6187 but can't merge the pr when all of them are broken

@debris debris mentioned this pull request Aug 1, 2017
Merged
@debris
Copy link
Collaborator

debris commented Aug 1, 2017 •
edited

tests fixed in #6132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NikVolf @debris @arkpar