This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Optimized PlainHasher hashing. Trie insertions are >15% faster #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Aug 17, 2017
debris
commented
Aug 17, 2017
util/benches/trie.rs
Outdated
} | ||
|
||
fn random_value(seed: &mut H256) -> Bytes { | ||
*seed = seed.sha3(); | ||
match seed[0] % 2 { | ||
1 => vec![seed[31];1], | ||
_ => seed.into_vec(), | ||
_ => seed.to_vec(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated benchmark fix
debris
changed the title
Optimized PlainHasher hashing. Trie insertions are ~10% faster
Optimized PlainHasher hashing. Trie insertions are >15% faster
Aug 17, 2017
I moved |
indentation wrong here: https://github.com/debris/plain_hasher/blob/master/src/lib.rs#L45 |
rphmeier
added
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 18, 2017
gavofyork
added
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
and removed
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
labels
Aug 20, 2017
@rphmeier updated readme and moved the repo to https://github.com/paritytech/plain_hasher I will also add core-devs as owners on crates.io once they fix this bug: rust-lang/crates.io#997 |
debris
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
labels
Aug 21, 2017
I don't really see why |
arkpar
added
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 28, 2017
debris
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
labels
Aug 28, 2017
@arkpar fixed |
arkpar
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlainHasher::write
before:PlainHasher::write
after:before:
after: