Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

updated bigint with optimized mul and from_big_indian #6323

Merged
merged 1 commit into from Aug 17, 2017
Merged

updated bigint with optimized mul and from_big_indian #6323

merged 1 commit into from Aug 17, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Aug 17, 2017 •
edited

bigint optimizations from paritytech/bigint#23

reading u256 is now 60% faster

old rlp benches:

test bench_decode_u256_value         ... bench:         118 ns/iter (+/- 7)
test bench_decode_u64_value          ... bench:          77 ns/iter (+/- 18)

new benches:

test bench_decode_u256_value         ... bench:          73 ns/iter (+/- 5)
test bench_decode_u64_value          ... bench:          80 ns/iter (+/- 32)

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 17, 2017
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 17, 2017
@debris debris merged commit 2129eda into master Aug 17, 2017
@debris debris deleted the updated_bigint branch August 17, 2017 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@debris @NikVolf