This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
jsonrpc panics gracefully shutdown client #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| fn wait_for_exit(client_service: &ClientService) { | ||
| fn wait_for_exit(client_service: &ClientService, server_handler: Option<Arc<PanicHandler>>) { |
There was a problem hiding this comment.
Instead of having two MayPanic (one of them as Option<Arc<PanicHandler>>) you could create just single PanicHandler and use forward_from on client_service and rpc_server (or PanicHandler).
tomusdrw
added
A5-grumble 🔥
Merged
debris
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
tomusdrw
added a commit
that referenced
this pull request
Mar 9, 2016
jsonrpc panics gracefully shutdown client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #555