Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

updated jsonrpc-core and http-server libs #642

Merged
merged 1 commit into from Mar 9, 2016
Merged

updated jsonrpc-core and http-server libs #642

merged 1 commit into from Mar 9, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 9, 2016

changes in jsonrpc-core:

  • IoHandler provides interior threadsafety

changes in jsonrpc-http-server:

  • IoHandler is not wrapped into mutex what improves performance if server is used on multiple threads
  • server constructor takes Arc<IoHandler> instead of moving IoHandler what makes IoHandler reusable for multiple rpc servers

changes in pr:

  • renamed HttpServer to RpcServer
  • renamed start_async to start_http

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Mar 9, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 9, 2016
debris added a commit that referenced this pull request Mar 9, 2016
@debris
Merge pull request #642 from ethcore/jsonrpc_update
abeb50b 
updated jsonrpc-core and http-server libs
@debris debris merged commit abeb50b into master Mar 9, 2016
@debris debris deleted the jsonrpc_update branch March 10, 2016 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@debris @NikVolf