Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

updated ethabi to version 4.0 #6742

Merged
merged 3 commits into from Oct 16, 2017
Merged

updated ethabi to version 4.0 #6742

merged 3 commits into from Oct 16, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Oct 13, 2017

part of #6360

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 13, 2017
@debris debris mentioned this pull request Oct 13, 2017
Closed
4 tasks
@5chdn 5chdn added this to the 1.9 milestone Oct 13, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 14, 2017
@debris
Copy link
Collaborator Author

debris commented Oct 15, 2017 •
edited

don't merge it for now. ethabi 4.0.0 has the same issue with strict encoding that 2.0.0 had

@debris debris added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 15, 2017
@debris debris mentioned this pull request Oct 15, 2017
Merged
@debris debris removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 15, 2017
@debris debris mentioned this pull request Oct 15, 2017
Closed
@debris
Copy link
Collaborator Author

debris commented Oct 15, 2017

closes #6594

@arkpar arkpar merged commit 8365f4d into master Oct 16, 2017
@arkpar arkpar deleted the ethabi4.0 branch October 16, 2017 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@debris @arkpar @5chdn