Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove redundant mut #6773

Merged
merged 5 commits into from Oct 15, 2017
Merged

Remove redundant mut #6773

merged 5 commits into from Oct 15, 2017

Conversation

0x7CFE
Copy link
Contributor

@0x7CFE 0x7CFE commented Oct 15, 2017

This PR removes unneeded mut specifiers across the codebase.

@0x7CFE 0x7CFE added the A0-pleasereview 🤓 Pull request needs code review. label Oct 15, 2017
@parity-cla-bot
Copy link

It looks like @0x7CFE hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@0x7CFE
Copy link
Contributor Author

0x7CFE commented Oct 15, 2017

In my case the only warnings left are:

warning: variable does not need to be mutable
   --> parity/target/release/build/ethcore-ipc-hypervisor-c1a2466723855f8b/out/service.rs.in:764:42
    |
764 |         modules.get_mut(&module_id).map(|mut module|
    |                                          ^^^^^^^^^^
    |
    = note: #[warn(unused_mut)] on by default

warning: variable does not need to be mutable
   --> parity/target/release/build/ethcore-ipc-hypervisor-c1a2466723855f8b/out/service.rs.in:775:42
    |
775 |         modules.get_mut(&module_id).map(|mut module|
    |                                          ^^^^^^^^^^

If I understand correctly, these sources are generated automatically. What file should I edit to remove these warnings as well?

@debris
Copy link
Collaborator

debris commented Oct 15, 2017

I believe it's ipc/hypervisor/src/service.rs.in

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 15, 2017
@debris debris merged commit 82c8dcc into master Oct 15, 2017
@debris debris deleted the refactoring/redundant-mut branch October 15, 2017 14:38
@0x7CFE
Copy link
Contributor Author

0x7CFE commented Oct 15, 2017

Oops, I was submitting final commit 730b80b when you merged the PR :) Should I open another PR for that one?

@0x7CFE
Copy link
Contributor Author

0x7CFE commented Oct 15, 2017

Final change in #6775

@5chdn 5chdn added this to the 1.9 milestone Oct 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants