Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add ECIP1017 to Morden config #6810

Merged
merged 3 commits into from Oct 20, 2017
Merged

Add ECIP1017 to Morden config #6810

merged 3 commits into from Oct 20, 2017

Conversation

whilei
Copy link
Contributor

@whilei whilei commented Oct 17, 2017

Uses era length of 2M blocks.

See https://github.com/ethereumproject/go-ethereum/blob/master/core/config/morden.json#L110 for congruent implementation in geth classic.

@parity-cla-bot
Copy link

It looks like @whilei hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@whilei
Copy link
Contributor Author

whilei commented Oct 17, 2017 •
edited

🤖 🧀

@parity-cla-bot
Copy link

It looks like @whilei signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 17, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 18, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 18, 2017

lgtm, do you mind also updating the bootnodes? https://github.com/ethereumproject/go-ethereum/blob/master/core/config/morden.json#L129-L135

had issues connecting to morden recently.

@whilei
Copy link
Contributor Author

whilei commented Oct 18, 2017 •
edited

Happy to -- I guess you mean for me to include unique nodes from https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/morden.json#L52-L56?

Update: done! ethereumproject/go-ethereum#370

@5chdn
Copy link
Contributor

5chdn commented Oct 19, 2017

No, I meant what I have written, to get working Morden boot nodes from Go-Etc. :-p

@whilei
Copy link
Contributor Author

whilei commented Oct 19, 2017 •
edited

Oh... wait, you mean updating the Parity bootnodes from geth? And including those changes in this PR as well?

@5chdn
Copy link
Contributor

5chdn commented Oct 19, 2017

Yes :)

@5chdn 5chdn added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 19, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 19, 2017

tests fail. what's causing this? cc @paritytech/ci

./scripts/validate_chainspecs.sh: 7: ./scripts/validate_chainspecs.sh: ./target/release/chainspec: not found

@whilei
Copy link
Contributor Author

whilei commented Oct 19, 2017 •
edited

I need to order a bumper sticker: A7-looksgoodtestsfail

@arkpar arkpar merged commit bbe9d73 into openethereum:master Oct 20, 2017
@5chdn 5chdn added the B0-patch label Oct 20, 2017
5chdn pushed a commit that referenced this pull request Oct 20, 2017
@whilei @5chdn
Add ECIP1017 to Morden config (#6810)
401e77a 
* Add ECIP1017 setting to Morden config

* Convert spaces to tabs

* Update Morden bootnodes to match Geth
arkpar pushed a commit that referenced this pull request Oct 20, 2017
@5chdn @arkpar
Add ECIP1017 to Morden config (#6810) (#6845)
0e4a06d 
* Add ECIP1017 setting to Morden config

* Convert spaces to tabs

* Update Morden bootnodes to match Geth
@whilei whilei mentioned this pull request Nov 9, 2017
Closed
@whilei whilei mentioned this pull request Nov 24, 2017
Merged
@meowsbits meowsbits mentioned this pull request Dec 1, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@whilei @parity-cla-bot @5chdn @arkpar @rphmeier