Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix JSON tracing for sub-calls. #6842

Merged
merged 5 commits into from Oct 30, 2017
Merged

Fix JSON tracing for sub-calls. #6842

merged 5 commits into from Oct 30, 2017

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 20, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 20, 2017
@arkpar
Copy link
Collaborator

arkpar commented Oct 24, 2017

Does this change instructions trace to be show pre-execution data, rather than post-execution?

@tomusdrw
Copy link
Collaborator Author

The state is still pre-execution (gas used, memory, stack, etc) although the trace should be printed only on successful gas calculation.
Because of that we were printing CREATE/CALL/DELEGATECALL instruction after all sub-call traces which looked weird.

Before:

..create initialization (depth: 1)
PUSH (depth: 2)
CREATE (depth: 1) // create executed

Now:

..create initialization (depth: 1)
CREATE (depth: 1) // create executed
PUSH (depth: 2)

@holiman
Copy link
Contributor

holiman commented Oct 25, 2017

Looks correct to me

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 26, 2017
@debris debris merged commit 39e2707 into master Oct 30, 2017
@debris debris deleted the td-evm-json branch October 30, 2017 04:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants