This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
warn when blacklisted account present in store #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
tomusdrw
approved these changes
Oct 24, 2017
|
Note: This will not warn if the blacklisted account is in the address book (will be just silently removed from there) |
arkpar
added
A7-looksgoodtestsfail 🤖
rphmeier
force-pushed
the
warn-blacklisted
branch
from
0b2da28
to
dd13526
Compare
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6799
It might not play well with setups where there are lots of accounts, but we should still do this check. Later we can optimize to store an addresses index if the key store is large enough.