Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Invalid enode address format on failed name resolution #6907

Closed
0x7CFE opened this issue Oct 27, 2017 · 0 comments · Fixed by #6970
Closed

Invalid enode address format on failed name resolution #6907

0x7CFE opened this issue Oct 27, 2017 · 0 comments · Fixed by #6970
Assignees
@debris @arkpar
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone
1.9 Velocity

Comments

@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 27, 2017 •
edited

If name resolution fails during boot node setup, parity exits with the following error message:

Invalid node address format given for a boot node: enode://8925b57acc144d035ca91b32b93a4503103b65c25d4164f2a6b56ed6f0093b96f560e3e8a592816376e7c652c6155a7c8924eb703d2c7a15da3b4973e4ae40c3@host1:30303

This may confuse and mislead user, because enode format is actually correct. In order to fix that, we should alter error reporting logic, so that message would contain the actual reason (failed name resolution). "Invalid node address format" should be reported only when enode format is really syntactically invalid.

Version info:

Parity/v1.8.1-beta-0e4a06d-20171020/x86_64-linux-gnu/rustc1.21.0
Ubuntu Linux 16.04.3
Installed via parity-deploy.
@0x7CFE 0x7CFE added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Oct 27, 2017
@0x7CFE 0x7CFE mentioned this issue Oct 27, 2017
Closed
@5chdn 5chdn added this to the 1.9 milestone Oct 29, 2017
@5chdn 5chdn added the P5-sometimesoon 🌲 Issue is worth doing soon. label Oct 29, 2017
0x7CFE added a commit that referenced this issue Nov 2, 2017
@0x7CFE
Adds validate_node_url() and refactors boot node check (#6907)
760b453
0x7CFE added a commit that referenced this issue Nov 2, 2017
@0x7CFE
Adds validate_node_url() and refactors boot node check (#6907)
d6b5798
@0x7CFE 0x7CFE mentioned this issue Nov 2, 2017
Merged
2 tasks
0x7CFE added a commit that referenced this issue Nov 6, 2017
@0x7CFE
Adds validate_node_url() and refactors boot node check (#6907)
1516fc1
debris added a commit that referenced this issue Nov 10, 2017
@debris
Merge pull request #6970 from paritytech/validate_node_url
e13204c 
Adds validate_node_url() and refactors boot node check (#6907)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debris debris

@arkpar arkpar

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging a pull request may close this issue.

Adds validate_node_url() and refactors boot node check (#6907) openethereum/parity-ethereum
4 participants
@debris @0x7CFE @arkpar @5chdn