Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update v1 Wallet Dapp #6935

Merged
merged 45 commits into from Nov 13, 2017
Merged

Update v1 Wallet Dapp #6935

merged 45 commits into from Nov 13, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 30, 2017 •
edited

  • Remove duplicated functionality from v1 wallet (dapps, Signer pop-over, Extension pop-over, Requests pop-over)
  • Adapt v1 Wallet API now uses the injected Ethereum Provider, as all other dapps
  • Remove split dapps from shell, unless functionality non-existent elsewhere (e.g. dapp-accounts, dapp-addresses, ... to be re-added once ported properly as stand-alone apps)
  • Add dapps for local testing injected providers (both Web3 & Parity)
  • Pull in @parity/api 2.1.x
  • Cleanup sourcemaps for production builds
  • Merge beta changes into Wallet
  • Disallow the deployment of multisig ([beta] Disallow builtin multisig deploy (only watch) #7014 for beta)

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Oct 30, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 31, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 1, 2017
@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 9, 2017
@jacogr jacogr mentioned this pull request Nov 10, 2017
Merged
@jacogr jacogr merged commit ce16097 into master Nov 13, 2017
@jacogr jacogr deleted the jg-v1-as-dapp branch November 13, 2017 08:31
@5chdn 5chdn added A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacogr @5chdn