Assorted improvements for ethstore and ethkey #6961

tomusdrw · 2017-11-01T22:58:37Z

Brute forcing presale wallet given a password list (ethstore)
Multi-threaded generation of prefix-matching addresses (ethkey)
Prefix-matching brain wallets (ethkey)
Brain wallets recovery phrases lookup (ethkey) - helps to find a correct phrase if you know the address you want to get yet you made a typo backing the phrase up (or forgot a word)

5chdn · 2017-11-01T23:03:12Z

Does this need docs?

tomusdrw · 2017-11-01T23:10:52Z

There are some (very undetailed) docs in the --help, I can add more if you want. Do we have a wiki page for these stuff too?

5chdn · 2017-11-01T23:19:13Z

No, only the READMEs afaik

DaleChristopher · 2017-11-02T04:37:47Z

GREAT!!!! but I'd very much appreciate some kind of instructions geared towards helping the end user/ non-programmer attempting to use this. It might seem straightforward to you guys but I have had zero training in coding and have been trying to figure out what i need to even run it for the last hours... >_<
I'm sure I will figure it out eventually but I'm teaching myself a new skill here with no prior experience. Some kind of basic step by step would be really helpful. @tomusdrw great work btw! cant wait to test it out!
trying to figure out how to "compile" something atm

debris · 2017-11-13T11:48:08Z

ethkey/src/brain_recover.rs

+		.map(|word| match known_words.get(word) {
+			None => {
+				info!("Invalid word '{}', looking for potential substitutions.", word);
+				let substitutions = generate_substitutions(word);


what if I defined words myself?

Then we can't help you. This recovery process is targeted at people who used parity-generated phrase but made a mistake while backing it up.
We could make a more generic recovery process (which allows you to provide your own dictionary) as an extra feature.

debris · 2017-11-13T12:03:25Z

ethkey/README.md

    ethkey generate random [options]
-    ethkey generate prefix <prefix> <iterations> [options]
-    ethkey generate brain <seed> [options]


this makes it backward incompatible. I was using this option a lot for my personal accounts

Bumped version of ethkey and ethstore and added relnotes llabel.

IMHO it's more consistent now, if you provide <seed> we don't really generate anything, we just print address info (similar to when you are providing the secret), there is a secret derivation in the background obviously, but I think it significantly differs from generate random and generate prefix commands.

… td-ethstore-crack

dkashitsyn · 2017-11-30T10:19:51Z

ethstore/cli/src/main.rs

+
+		let mut handles: Vec<thread::JoinHandle<_>> = Vec::new();
+		let threads = num_cpus::get();
+		for _ in 0..threads {


I may be wrong but looks like Rayon may be used here instead of raw threads.

svyatonik · 2017-11-30T10:45:07Z

ethkey/cli/src/main.rs

 	}
+
+	if let Ok(solution) = rx.recv() {


Is it possible that recv will return Err here? It only fails when sender is destroyed an here are max+1 senders, of which this last 1 is never destroyed. So it looks like that if all threads have failed with an error, we will hang in this recv call. I can be missing something, though :)

Good points, thanks. Will addresss both by switching to rayon as suggested by @0x7CFE

svyatonik · 2017-11-30T10:47:43Z

ethkey/cli/src/main.rs

+		let tx = tx.clone();
+		handles.push(thread::spawn(move || match t() {
+			Ok(solution) => {
+				tx.send(solution).expect("Receiving end never dropped.");


When first thread founds a solution, it is received via rx.recv() and function returns => receiving end is destroyed. Since we do not wait for other threads on successful return (is it intended?), other threads are still running and when next t() call will succeed, this would lead to panic. Not sure it is possible to have several solutions in these tasks, though...

tomusdrw · 2017-11-30T15:36:00Z

Decided to use threadpool instead of rayon, since I'm using a regular iterator and also addressed two comments from Slava by that.

* Update config.full.toml * Update mod.rs * Patch 1 (#1) * Iterate over both buffered and unbuffered database entries * Fix iterator issues * no default uncles * prepare cargo configuration for upload of crates * update bigint version number * update ethcore-bigint version * rename hash crate to keccak-hash * update memorydb * update rlp * update patricia-trie cargo.toml * use error-chain in ethcore-network * interleaved-ordered 0.1.1 * static linking for snappy * removed redundant imports * Add the desktop file for the snap Now that we have added plugs to allow accessing the display, the snap needs a desktop file. And bonus point, it will appear on the menu when it's installed, and once you make a stable relase, it will appear in the gnome software center app! So, one-click install for parity :) Closes: #7056 * update icon for desktop * Properly display Signer errors (Snackbar display popup) (#7053) * Update to fixed @parity/ui (Errors component) * Update ParityBar radius to align with Snackbar/Errors * Update to latest @parity/ui * Update dependencies @parity/signer-plugin-* * Really pull in @parity/signer-plugin-* deps * CHANGELOG for 1.7.8, 1.7.9, 1.8.2, and 1.8.3 (#7055) * Update changelog for 1.7.8 stable * Update changelog for 1.7.9 stable * Improve wording in Changelog * Update changelog for 1.8.2 beta * Update changelog for 1.8.3 beta * [ci skip] js-precompiled 20171115-103846 * ECIP-1039: Monetary policy rounding specification Fix potential rounding errors between geth and parity in the long-term future. * Change reward calculation to only use divide once * SecretStore: servers set change session api (#6925) * SecretStore: first key versions flush * SecretStore: key versions in encryption session * SecretStore: flush key versions negotiation session * SecretStore: connected key version negotiation session to cluster * SecretStore: cluster sessions container refactoring * SecretStore: flush * SecretStore: flush key versions * SecretStore: flush * SecretStore: delegation proto * SecretStore: decryption_session_is_delegated_when_node_does_not_have_key_share * SecretStore: fixed version in decryption session * SecretStore: signing_session_is_delegated_when_node_does_not_have_key_share * SecretStore: started restoring admin sessions * SecretStore: restoring admin sessions * SecretStore: removed obsolete ShareRemove && ShareMove sessions * SecretStore: ShareAdd math tests only require old_t+1 nodes * SecretStore: ShareAdd revamp using new math backend * SecretStore: do not include isolated nodes into consensus_group * SecretStore: ServersSetChange + ShareAdd revamp * removed debug printlns * SecretStore: key version negotiation tests * SecretStore: removed debug/merge artifacts * SecretStore: fixed master node selection * SecretStore: cleanup + tests + fixes * SecretStore: uncommented tests * SecretStore: cleaning up * SecretStore: cleaning up + tests * SecretStore: cleaning up * SecretStore: cleaning up && tests * SecretStore: fixing TODOs * SecretStore: fixing TODOs + cleanup * SecretStore: fixing TODOs * SecretStore: nodes_add_to_the_node_with_obsolete_version * SecretStore: nodes_add_fails_when_not_enough_share_owners_are_connected * SecretStore: tests * SecretStore: signing && delegation tests * SecretStore: signing && decryption tests when some nodes are isolated * SecretStore: sessions_are_removed_when_initialization_fails * SecretStore: ceaning up * SecretStore: removed obsolete comments * SecretStore: signing_session_completes_if_node_does_not_have_a_share * SecretStore: initial ServersSetChange API * SecretStore: added secretstore_signServersSet RPC * SecretStore: ChangeServersSet parse tests * SecretStore: fixes after manual ServersSetChange tests * lost file * fixed network ports overlap in tests * lost files * fix tests on patricia-trie * updated eth-secp256k1 * Fix no-default-features. * Parse payload from panic Impl payload empty str is none Update tests Clean Update wasm-tests * Allow localUrl in manifest * Improve Github Issue Template: IT CROWD approved version. * Remove seperator that causes issue descriptions to become headlines sometimes * Add to all icon_url places * Add appId as needed to local dapps * localUrl only from manifest * Update panic_payload.rs * Use query-string for search parsing * spaces to tabs. * Add localUrl to serialization * Make storage_read/write return nothing * Update gas values * Update wasm-tests * Cleanup debug info * Remove debug log * Optimize & group dapp requests (#7083) * Group similar methods in same grouping * Add a shell_getMethodGroups API * Small code clean changes * Fix bug dapp.name not showing * Additional error handling * Store sources in own map * Remove observable variables where not needed * Refactor code and fix bug dapp not showing on approve * [ci skip] js-precompiled 20171121-150329 * Remove unused and duplicated files in js-old (#7082) * Cleanup v1 build process, application-only * Remove built-in dapps from build (duplicated) * User @parity/api instead of local version * Update references to @parity/abi * Remove unused js-old api/abi folders * Remove duplicated v1 jsonrpc * Cleanup unused routes * Update manifest with wallet image * Update wallet logo * Re-add missing test.sh * Update rpc mocks * Update tests for Providers * Use flex for iframe & status * Additional cleanups (Home screen for embed) * Keep statusbar fixed (and non-overallping with dapps) * [ci skip] js-precompiled 20171121-164807 * Cleanup top bar, add Home icon for navigation (#7118) * Localise images to config.js file * Remove sample status plugin (commented) * Update image references from config * Remove Unknown capability & Capable (only display actions) * Update to @parity/ui 2.2.14 * Add Home icon on statusbar (go back) * 2.2.14 -> 2.2.x * Builtin dapp icons where dappreg not available * [ci skip] js-precompiled 20171122-140247 * fixed RotatingLogger after migrating to new arrayvec * Update packages, pull in compiled-only repos (#7125) * Update packages, pull in compiled-only repos * Update js-precompiled to point to js-dist-paritytech * Trigger both js & js-old builds to force update * Update to bring scripts 100% in-sync * Fixed build && test (#7128) * fixed build && test * fixed rpc tests * Update js-precompiled ref, trigger JS build * Add test for ECIP1017 at block 250000000 * Wrong era used in ECIP1017 test It is era 49, and should correspond to ECIP1017/ECIP1039's era 50. * [ci skip] js-precompiled 20171124-124119 * Push to correct shell branch (#7135) * Push to correct shell branch * Trigger both js & js-old builds * [ci skip] js-precompiled 20171124-134823 * pwasm-run-test utility * WASM Remove blockhash error (#7121) * Remove blockhash error * Update tests. * Pull in new dapp-{methods,visible} dapps (#7150) * [ci skip] js-precompiled 20171128-091552 * fixes typo in user config path (#7159) * Cleanup JS build artifacts (#7164) * Cleanup JS build artifacts * Trigger js & js-old * [ci skip] js-precompiled 20171129-135441 * Use git flag to remove old js artifacts (#7165) * [ci skip] js-precompiled 20171129-144917 * Remove *.css.map & *.js.map (#7168) * [ci skip] js-precompiled 20171129-172021 * Delete unused package.json (dist) (#7173) * [ci skip] js-precompiled 20171130-103432 * Assorted improvements for ethstore and ethkey (#6961) * Testing many passwords for presale wallet. * Add multiple threads. * WiP: ethkey brain wallets recover. * Refactor pre-sale-wallet cracking. * Generate in multiple threads. Brain with prefix. * Validate bain wallet phrase. * Brain wallet recovery. * Self-review fixes. * Fix tests. * More docs. * Bump versions. * Remove cmd_find from borked merge. * Update wasm submodules. * Use threadpool. * upper limit is gas limit * 10 in estimate gas * React 16 (#7174) * Update packages to use React 16 * Rollback to react-router v3 * Use component instead of pure one * Remove warning about mobx * Make webpack load css from @parity/ui * Update enzyme to support react16 * Fix lint * Use @parity/ui v3 * Update refs of plugin-signer-* deps * Exclude plugin-signer-* from babel processing * Reupdate refs to old method * Update refs again * [ci skip] js-precompiled 20171201-114538 * pwasm-run-test utility upgrade * Removed ethcore-util dependency from ethcore-network (#7180) * Removed ethcore-util dependency * Removed snappy * New account selector UI in top bar (#7179) * Add a dropdown popup for account selector * Install sui latest version for hideOnScroll bug fix * Update ui * Update package-lock after rebase * Require parity/ui v3.0.3 * Pass accountStore as props * Require parity/ui v3.0.4 * [ci skip] js-precompiled 20171204-115345 * Update mocha import stubs (#7191) * Update mocha import stubs * Add .md files to ignore list * [ci skip] js-precompiled 20171205-084709 * Update FirstRun for UI-2 (#7195) * WIP * Update after @parity/ui update * Update to latest * Update semver for @parity * Update & -> & * [ci skip] js-precompiled 20171205-102703 * Maximum uncle count transition (#7196) * Enable delayed maximum_uncle_count activation. * Fix tests. * Defer kovan HF. * mistake comment in calc difficulty (#7154) * Send each log as a separate notifications. (#7175) * Update config.full.toml * Revert "Patch 1 (#1)" (#2) This reverts commit 2fa0af6. * Update usd_per_tx test * Fix tests * Fix initial_minimum

tomusdrw added 10 commits September 28, 2017 16:39

Testing many passwords for presale wallet.

91940ba

Merge branch 'master' into td-ethstore-crack

ada0e24

Add multiple threads.

eef3674

WiP: ethkey brain wallets recover.

aecdaa6

Merge branch 'master' into td-ethstore-crack

94d1014

Refactor pre-sale-wallet cracking.

e460201

Generate in multiple threads. Brain with prefix.

661be12

Validate bain wallet phrase.

5be468e

Brain wallet recovery.

07f4afc

Self-review fixes.

8ac1559

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 1, 2017

5chdn added this to the 1.9 milestone Nov 1, 2017

5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Nov 1, 2017

Fix tests.

ff0c97d

tomusdrw added 2 commits November 3, 2017 12:30

Merge branch 'master' into td-ethstore-crack

76e61b1

More docs.

dc42870

debris reviewed Nov 13, 2017

View reviewed changes

debris added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 13, 2017

tomusdrw and others added 5 commits November 13, 2017 13:13

Merge branch 'master' into td-ethstore-crack

17e4e72

Bump versions.

270e403

Merge branch 'td-ethstore-crack' of github.com:paritytech/parity into…

dcbda1f

… td-ethstore-crack

Remove cmd_find from borked merge.

ffd7211

Merge branch 'master' into td-ethstore-crack

c3d1be4

tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Nov 20, 2017

tomusdrw removed the A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. label Nov 20, 2017

5chdn mentioned this pull request Nov 22, 2017

Parity Account Password #7103

Closed

Merge branch 'master' into td-ethstore-crack

261006f

dkashitsyn reviewed Nov 30, 2017

View reviewed changes

Update wasm submodules.

f8276cf

svyatonik reviewed Nov 30, 2017

View reviewed changes

tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 30, 2017

Use threadpool.

70b3b97

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 30, 2017

svyatonik approved these changes Dec 1, 2017

View reviewed changes

svyatonik added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 1, 2017

svyatonik merged commit 7663451 into master Dec 1, 2017

svyatonik deleted the td-ethstore-crack branch December 1, 2017 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assorted improvements for ethstore and ethkey #6961

Assorted improvements for ethstore and ethkey #6961

tomusdrw commented Nov 1, 2017

5chdn commented Nov 1, 2017

tomusdrw commented Nov 1, 2017

5chdn commented Nov 1, 2017

DaleChristopher commented Nov 2, 2017 •

edited

debris Nov 13, 2017

tomusdrw Nov 13, 2017

debris Nov 13, 2017

tomusdrw Nov 13, 2017

dkashitsyn Nov 30, 2017

svyatonik Nov 30, 2017

tomusdrw Nov 30, 2017

svyatonik Nov 30, 2017

tomusdrw commented Nov 30, 2017

Assorted improvements for ethstore and ethkey #6961

Assorted improvements for ethstore and ethkey #6961

Conversation

tomusdrw commented Nov 1, 2017

5chdn commented Nov 1, 2017

tomusdrw commented Nov 1, 2017

5chdn commented Nov 1, 2017

DaleChristopher commented Nov 2, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomusdrw commented Nov 30, 2017

DaleChristopher commented Nov 2, 2017 •

edited