This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Events in WASM runtime #6967
Merged
Events in WASM runtime #6967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
debris
approved these changes
Nov 10, 2017
debris
added
A8-looksgood 🦄
|
@fckt can you also review it? and merge if it looks good |
|
looks good. Tested on dev chain also. |
rphmeier
reviewed
Nov 12, 2017
| topics.resize(topic_count as usize, H256::zero()); | ||
| for i in 0..topic_count { | ||
| let offset = i.checked_mul(32).ok_or(UserTrap::MemoryAccessViolation)? | ||
| .checked_add(topic_ptr).ok_or(UserTrap::MemoryAccessViolation)?; |
There was a problem hiding this comment.
checked_mul here seems like overkill given that 3 is the max value of i.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.