This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
WASM parse payload from panics #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impl payload empty str is none Update tests Clean Update wasm-tests
|
It looks like @pepyakin signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
pepyakin
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
debris
suggested changes
Nov 21, 2017
ethcore/wasm/src/runtime.rs
Outdated
|
|
||
| Err(UserTrap::Panic(msg).into()) | ||
| } | ||
| let payload_len = context.value_stack.pop_as::<i32>()? as u32; |
There was a problem hiding this comment.
use tabs instead of spaces
There was a problem hiding this comment.
Thanks! It happened after I copied this chunk after rustfmt : (
debris
added
A4-gotissues 💥
pepyakin
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
NikVolf
approved these changes
Nov 21, 2017
debris
approved these changes
Nov 21, 2017
tomusdrw
pushed a commit
that referenced
this pull request
Dec 4, 2017
WASM parse payload from panics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a new format of a panic payload (see openethereum/pwasm-std#42).
So if a contract has been compiled with a
pwasm-std/panic_with_msgfeature then it's panic messages will be printed (by default they are stripped).Example of a panic message: