Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Local dapp development URL #7100

Merged
merged 8 commits into from Nov 21, 2017
Merged

Local dapp development URL #7100

merged 8 commits into from Nov 21, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 20, 2017

Add an optional (only de-serialised for local/development dapps) option to the manifest.json file, localUrl.

The UI, when it finds this option, will load that url to serve the application - basically it allows you to run a server for the dapp in local development, and have tools such as hot-reloading available to the dapp.

cc @amaurymartiny

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Nov 20, 2017
@5chdn 5chdn added this to the 1.9 milestone Nov 20, 2017
@jacogr jacogr requested a review from tomusdrw November 21, 2017 14:13
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 21, 2017
@amaury1093
Copy link
Contributor

Working for me 👍 managed to run a dapp served by it's own dev server.

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 21, 2017
@debris debris merged commit 3092543 into master Nov 21, 2017
@debris debris deleted the jg-dapp-localUrl branch November 21, 2017 19:42
@tomusdrw
Copy link
Collaborator

@paritytech/ci Build status is broken on this one, seems that the rust compilation/tests did not run at all on this PR. The modified files detection didn't work all that well, it should take all changes on the branch not only last commit. Created a separate issue: #7130

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants