This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
parity-version pr reopen #7136
Merged
parity-version pr reopen #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
removed unused util deps and features trigger buildbot again only kvdb links rocksdb snappy linker issues
debris
force-pushed
the
parity-version
branch
from
8030ea6
to
d7c28d0
Compare
|
tests fail |
|
yes, cause linking C++ libraries is somehow broken and behaves in unpredictable way 😕 |
|
Needs a rebase. Snappy issues should be fixed in master now. |
5chdn
added
A3-inprogress ⏳
debris
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Dec 21, 2017
Cargo.toml
Outdated
| @@ -94,13 +95,12 @@ ui-precompiled = [ | |||
| ui-enabled = ["dapps"] | |||
| dapps = ["parity-dapps"] | |||
| jit = ["ethcore/jit"] | |||
| dev = ["clippy", "ethcore/dev", "ethcore-util/dev", "ethsync/dev", "parity-rpc/dev", "parity-dapps/dev"] | |||
There was a problem hiding this comment.
Why is ethcore-util/dev removed from here?
There was a problem hiding this comment.
ethcore-util/dev does not exist any more
There was a problem hiding this comment.
Fair enough, anyway see #7355
tomusdrw
added
A7-looksgoodtestsfail 🤖
tomusdrw
added
A8-looksgood 🦄
tomusdrw
pushed a commit
that referenced
this pull request
Feb 14, 2018
* parity-version module split from util removed unused util deps and features trigger buildbot again only kvdb links rocksdb snappy linker issues * rm snappy * fixed old version imports
5chdn
pushed a commit
that referenced
this pull request
Feb 14, 2018
* update back-references more aggressively after answering from cache (#7578) * Flush keyfiles. Resolves #7632 (#7868) * Fix wallet import (#7873) * rpc: generate new account id for imported wallets * ethstore: handle duplicate wallet filenames * ethstore: simplify deduplication of wallet file names * ethstore: do not dedup wallet filenames on update * ethstore: fix minor grumbles * parity-version pr reopen (#7136) * parity-version module split from util removed unused util deps and features trigger buildbot again only kvdb links rocksdb snappy linker issues * rm snappy * fixed old version imports * Move updater metadata to Cargo.toml of parity-version. (#7832) * Update version. * Bump parity version. * Fix version. * Fix compilation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.