Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix/Update method permissions #7233

Merged
merged 3 commits into from Dec 7, 2017
Merged

Fix/Update method permissions #7233

merged 3 commits into from Dec 7, 2017

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Dec 7, 2017

  • Fix Approving some permissions don't save them in localStorage paritytech/dapp-dapp-methods#6
  • Change of the approval system: "Approve" approves all the methods in a methodGroup. (e.g. if a dapp only requests 2 methods from the 'shell' methodGroup, clicking on "Approve" on the orange bar will approve all the 'shell' methods for this dapp). The Reason is to avoid the user for approving multiple time accountCreate methodGroup for the wallet, because the accountCreate methods are not requested at the same time.
  • Performance improve: remove () => {...} functions in react render
  • CSS fix

@parity-cla-bot
Copy link

It looks like @amaurymartiny signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2017
@jacogr jacogr merged commit f6f7a87 into master Dec 7, 2017
@jacogr jacogr deleted the am-fix-permissions branch December 7, 2017 14:10
@5chdn 5chdn added this to the 1.9 milestone Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approving some permissions don't save them in localStorage
4 participants