This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Simplify status + content display overlaps/page fixing #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Dec 12, 2017
| )) | ||
| } | ||
| </div> | ||
| <Page className={ styles.dapps }> |
There was a problem hiding this comment.
I'm modifying this heavily in #7266, I think you can remove it from this PR. It would save some time for me or you resolving conflicts
There was a problem hiding this comment.
Yup, just made a comment - think we need this one in first and then make sure that your still works 100% as expected. I'm worried since the top layout is now not a fixed bar anymore, rather a proper layout. (Needed to get done since we have had complaints about overlaps)
There was a problem hiding this comment.
Agreed, i'll rebase mine on yours.
amaury1093
approved these changes
Dec 12, 2017
amaury1093
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7242 - error bar is still always visible, however doesn't overlap