This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
New Homepage #7266
Merged
New Homepage #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
added
A3-inprogress ⏳
jacogr
reviewed
Dec 12, 2017
js/src/shellMiddleware.js
Outdated
| ); | ||
| return true; | ||
| } | ||
| case 'shell_setAppPinned': { |
There was a problem hiding this comment.
Empty line before to be consistent?
jacogr
reviewed
Dec 12, 2017
js/src/shellMiddleware.js
Outdated
| ); | ||
| return true; | ||
| } | ||
| case 'shell_setMethodPermissions': { |
There was a problem hiding this comment.
Empty line before to be consistent?
jacogr
reviewed
Dec 12, 2017
js/src/Dapps/dapps.js
Outdated
| const { availability } = this.props; | ||
| const applications = [].concat(this.store.visibleLocal, this.store.visibleViews, this.store.visibleBuiltin, this.store.visibleNetwork); | ||
| const pinned = this.store.pinnedApps; // Pinned apps | ||
| const unpinnedVisible = this.store.visibleApps.filter(app => // Visible apps that are not pinned |
There was a problem hiding this comment.
This should probably be in the store? (Can be computed?)
added 2 commits
December 12, 2017 15:08
amaury1093
force-pushed
the
am-new-ui
branch
from
c2389d0
to
66706f9
Compare
|
Rebased & fixed comments. |
amaury1093
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
|
are parity-news still a thing? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7224:
Only show dapps icon
Add possibility to pin/unpin a dapp (quick-launch)
To browse all dapps, there a dapp called "Browse Dapps"
Possibility to add/remove dapp from homepage, or to open to try.
Feedback welcome.
[Edit] Updated scrot.