This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix dappIcon & Fix Signer Pending #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Dec 19, 2017
| return false; | ||
| } | ||
| }); | ||
| require('babel-register')(); |
There was a problem hiding this comment.
Explanation: All @parity/* export transpiled JS, so no need to babelify them again as done before.
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: @tomusdrw I finally decided not to change to the notification UI in the extension for now: it was way too much headache (popup placed randomly, icons not loading...) for not much result. We can do that when we decide to clean the extension, cf your issue.