Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Wasm runtime update #7356

Merged
merged 3 commits into from Dec 22, 2017
Merged

Wasm runtime update #7356

merged 3 commits into from Dec 22, 2017

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Dec 21, 2017

  • call now obliged to specify gas limit
  • overall update of wasm-tests and corresponding gas costs
  • some environment for calls was fixed to be passed correctly

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 21, 2017
@@ -69,17 +69,17 @@ pub const SIGNATURES: &'static [UserFunctionDescriptor] = &[
),
Static(
"_ccall",
&[I32; 6],
&[I64, I32, I32, I32, I32, I32],
Copy link
Contributor

@pepyakin pepyakin Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really a correct signature? In pwasm-std/pwasm-ethereum it is defined like

		pub fn ccall(
			gas: i64,
			address: *const u8,
			val_ptr: *const u8,
			input_ptr: *const u8,
			input_len: u32,
			result_ptr: *mut u8,
			result_len: u32,
		)i32;

which have 7 arguments, but in code above it have only 6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, regular call lacks dedicated test also

@pepyakin pepyakin added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 21, 2017
@NikVolf NikVolf added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Dec 21, 2017
@pepyakin
Copy link
Contributor

pepyakin commented Dec 21, 2017

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 21, 2017
@pepyakin pepyakin added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 22, 2017
@NikVolf NikVolf merged commit 82340c0 into master Dec 22, 2017
@NikVolf NikVolf deleted the wasm-uplift branch December 22, 2017 18:54
@5chdn 5chdn added this to the 1.9 milestone Jan 2, 2018
@NikVolf NikVolf restored the wasm-uplift branch January 5, 2018 15:50
@debris debris deleted the wasm-uplift branch April 10, 2018 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants