This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix default CORS settings. #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomusdrw
commented
Dec 27, 2017
tomusdrw
commented
- Expect a list in the config file.
tomusdrw
added
A0-pleasereview 🤓
kirushik
approved these changes
Dec 27, 2017
andresilva
approved these changes
Dec 27, 2017
parity/cli/mod.rs
Outdated
| @@ -466,7 +466,7 @@ usage! { | |||
| "--jsonrpc-threads=[THREADS]", | |||
| "Turn on additional processing threads in all RPC servers. Setting this to non-zero value allows parallel cpu-heavy queries execution.", | |||
|
|
|||
| ARG arg_jsonrpc_cors: (Option<String>) = None, or |c: &Config| otry!(c.rpc).cors.clone(), | |||
| ARG arg_jsonrpc_cors: (String) = "none", or |c: &Config| otry!(c.rpc).cors.as_ref().map(|vec| vec.join(",")), | |||
| "--jsonrpc-cors=[URL]", | |||
| "Specify CORS header for JSON-RPC API responses.", | |||
There was a problem hiding this comment.
Maybe add: "Special options: "all", "none"."
There was a problem hiding this comment.
Good point, thanks! Done.
parity/cli/mod.rs
Outdated
| @@ -538,7 +538,7 @@ usage! { | |||
| "--ipfs-api-hosts=[HOSTS]", | |||
| "List of allowed Host header values. This option will validate the Host header sent by the browser, it is additional security against some attack vectors. Special options: \"all\", \"none\".", | |||
|
|
|||
| ARG arg_ipfs_api_cors: (Option<String>) = None, or |c: &Config| otry!(c.ipfs).cors.clone(), | |||
| ARG arg_ipfs_api_cors: (String) = "none", or |c: &Config| otry!(c.ipfs).cors.as_ref().map(|vec| vec.join(",")), | |||
| "--ipfs-api-cors=[URL]", | |||
| "Specify CORS header for IPFS API responses.", | |||
There was a problem hiding this comment.
Same as above regarding special options.
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.