Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Signer updates from global Redux state #7452

Merged
merged 4 commits into from Jan 4, 2018
Merged

Signer updates from global Redux state #7452

merged 4 commits into from Jan 4, 2018

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 4, 2018

Closes #7369

  1. Remove unused layout
  2. Update Signer to use pending from Redux state (with isSending flag)
  3. Update to latest @parity/shared

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 4, 2018
amaury1093
amaury1093 approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good and works.

@amaury1093 amaury1093 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 4, 2018
@jacogr jacogr merged commit c417f01 into master Jan 4, 2018
@jacogr jacogr deleted the jg-signer branch January 4, 2018 12:13
@5chdn 5chdn added this to the 1.9 milestone Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacogr @amaury1093 @5chdn