This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
More thorough changes detection #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paritytech/ci please review. |
kirushik
added
A0-pleasereview 🤓
kirushik
force-pushed
the
more_thorough_changes_detection
branch
2 times, most recently
from
d2ea190
to
bceb25b
Compare
tomusdrw
approved these changes
Jan 5, 2018
tomusdrw
added
A8-looksgood 🦄
jacogr
approved these changes
Jan 5, 2018
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.
Closes #6507
kirushik
force-pushed
the
more_thorough_changes_detection
branch
from
bceb25b
to
30e6e99
Compare
debris
approved these changes
Jan 8, 2018
|
let's merge it after #7086 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically trades false-negatives ("dumb" last commit not touching Rust on a Rust-touching branch) for false-positives (all builds against
stableandbetawill run all tests almost always).This seems to be a reasonable tradeoff atm.
Closes #6507