Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Returning number of transactions pending in block not queue #750

Merged
merged 3 commits into from Mar 17, 2016

Conversation

tomusdrw
Copy link
Collaborator

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Mar 17, 2016
@arkpar arkpar added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 17, 2016
@arkpar
Copy link
Collaborator

arkpar commented Mar 17, 2016

block_pending name is a little non descriptive, since it is a number of transactions. Looks good otherwise

@tomusdrw
Copy link
Collaborator Author

Updated.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Mar 17, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 17, 2016
@@ -236,7 +236,9 @@ impl<C, S, A, M, EM> Eth for EthClient<C, S, A, M, EM>
fn block_transaction_count_by_number(&self, params: Params) -> Result<Value, Error> {
from_params::<(BlockNumber,)>(params)
.and_then(|(block_number,)| match block_number {
BlockNumber::Pending => to_value(&U256::from(take_weak!(self.miner).status().transaction_queue_pending)),
BlockNumber::Pending =>to_value(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

gavofyork added a commit that referenced this pull request Mar 17, 2016
Returning number of transactions pending in block not queue
@gavofyork gavofyork merged commit c88601a into master Mar 17, 2016
@gavofyork gavofyork deleted the tx_block_pending branch March 17, 2016 12:29
@arkpar arkpar added this to the 1.0 Parity milestone Mar 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants