Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[Beta] Backports #7945

Merged
merged 3 commits into from Feb 19, 2018
Merged

[Beta] Backports #7945

merged 3 commits into from Feb 19, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva added M4-core ⛓ Core client code / Rust. A8-backport 🕸 Pull request is already reviewed well in another branch. labels Feb 19, 2018
@codecov-io
Copy link

codecov-io commented Feb 19, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (beta@9d697c5). Click here to learn what that means.
The diff coverage is 86.99%.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #7945   +/-   ##
=======================================
  Coverage        ?   76.56%           
=======================================
  Files           ?      658           
  Lines           ?    93001           
  Branches        ?        0           
=======================================
  Hits            ?    71210           
  Misses          ?    21791           
  Partials        ?        0
Impacted Files Coverage Δ
ethcore/types/src/blockchain_info.rs 0% <ø> (ø)
ethcore/src/trace/types/localized.rs 100% <ø> (ø)
ethcore/src/tests/evm.rs 92.85% <ø> (ø)
ethkey/src/extended.rs 92.33% <ø> (ø)
ethcore/src/trace/db.rs 93.41% <ø> (ø)
ethkey/src/lib.rs 66.66% <ø> (ø)
ethcore/light/src/net/mod.rs 48.94% <ø> (ø)
ethcore/types/src/snapshot_manifest.rs 97.14% <ø> (ø)
dapps/src/endpoint.rs 90.9% <ø> (ø)
ethcore/light/src/types/request/batch.rs 95.49% <ø> (ø)
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d697c5...1019879. Read the comment docs.

tzdybal and others added 3 commits February 19, 2018 14:19
@tzdybal @andresilva
ECIP 1041 - Remove Difficulty Bomb (#7905)
6003ec1 
Enable difficulty bomb defusion at block:
 - 5900000 on Ethereum Classic mainnet,
 - 2300000 on morden testnet.

Reference:
https://github.com/ethereumproject/ECIPs/blob/master/ECIPs/ECIP-1041.md
@asymmetric @andresilva
spec: Validate required divisor fields are not 0 (#7933)
c73a38c 
* Add validate_non_zero function

It's used to validate that a Spec's uint field used as a divisor is not zero.

* Add deserialize_with to gas_limit_bound_divisor

Prevents panics due to divide-by-zero on the gas_limit_bound_divisor
field.

* Add deserialize_with to difficulty_bound_divisor

Prevents panics due to divide-by-zero on the difficulty_bound_divisor
field.

* Add validate_optional_non_zero function

Used to validate Option<Uint> divisor fields.

* Use deserialize_with on optional divisor fields.

* Add #[serde(default)] attribute to divisor fields

When using `#[serde(deserialize_with)]`, `#[serde(default)]` must be specified so that missing
fields can be deserialized with the deserializer for `None`.
@NikVolf @andresilva
Kovan WASM fork code (#7849)
1019879 
* kovan fork code

* introduce ethcore level vm_factory and let it fail

* fix json tests

* wasmcosts as option

* review changes

* wasm costs in parser

* fix evm tests

* review fixes

* fix test

* remove redundant json field
@5chdn 5chdn merged commit 804ddfe into beta Feb 19, 2018
@5chdn 5chdn deleted the andre-beta-backports branch February 19, 2018 15:05
@5chdn 5chdn added this to the Patch milestone Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andresilva @codecov-io @5chdn @tzdybal @asymmetric @NikVolf