Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing future-current transactions clash #802

Merged
merged 1 commit into from Mar 23, 2016
Merged

Fixing future-current transactions clash #802

merged 1 commit into from Mar 23, 2016

Conversation

tomusdrw
Copy link
Collaborator

  1. Because TransactionSet wasn't handling conflicts on it's own there was a possibility that we will endup with by_priority.len() != by_address.len().
  2. The situation could happen when one of the clashing transactions was inserted to future, and later there was same transaction that was inserted to current (we would end up with same (sender,nonce) in both current and future)
  3. Later when transactions are moved between future and current we could accidentally end up with situation from point 1.
  4. Situation 1. is not crashing the system until we call enforce_limit which would detect the inconsistency.

Fixes #801

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Mar 23, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 23, 2016
@gavofyork gavofyork merged commit 038b67c into master Mar 23, 2016
@tomusdrw tomusdrw deleted the tx_queue_bugs branch April 9, 2016 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants