Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Syntax helpers for IPC RPC #809

Merged
merged 5 commits into from Mar 25, 2016
Merged

Syntax helpers for IPC RPC #809

merged 5 commits into from Mar 25, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Mar 24, 2016

  • is almost only for code generation, so that incoming stream would dispatch to ipc interface methods without any extra code
  • the only file of interest should be ipc/codegen/codegen.rs and tests/example.rs
  • IpcInterface itself is subject to change and non-essential in the current state (just a draft)
  • further optimizations should come to reduce mem copies
  • only handles method invocation made by value (no &)
  • transport agnostic
  • different serialization methods can be easily replaced/added during compile time with example at tests/build.rs

@NikVolf NikVolf added the A0-pleasereview 🤓 Pull request needs code review. label Mar 24, 2016
}

fn push_invoke_signature_aster (
builder: &aster::AstBuilder,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horrible whitespacing for a few lines here.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 25, 2016
@gavofyork gavofyork merged commit 3f04f4e into master Mar 25, 2016
@gavofyork gavofyork deleted the ipc-syntax branch March 25, 2016 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants