Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[stable] Fix scripts. Force JS rebuild. #8144

Merged
merged 1 commit into from Mar 19, 2018
Merged

[stable] Fix scripts. Force JS rebuild. #8144

merged 1 commit into from Mar 19, 2018

Conversation

tomusdrw
Copy link
Collaborator

No description provided.

@tomusdrw tomusdrw added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration. labels Mar 17, 2018
@General-Beck
Copy link
Contributor

bulletproof logic!

@tomusdrw
Copy link
Collaborator Author

@General-Beck We don't care for that optimization for stable/beta (it's really only useful for PRs and master). Everytime we merge pull request we want to the build to proceed. Right now it doesn't work at all.

@General-Beck
Copy link
Contributor

@tomusdrw I agree. optimization from 1.10 +

jacogr
jacogr approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See no reason to complicate matters with the number of backports that goes in, i.e. it is low volume and being bullet-proof is better.

@tomusdrw tomusdrw merged commit dc8d6d8 into stable Mar 19, 2018
@tomusdrw tomusdrw deleted the td-fix-js branch March 19, 2018 08:15
@5chdn 5chdn added this to the Patch milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomusdrw @General-Beck @jacogr @5chdn