Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Updated jsonrpc to include latest backports (beta) #8181

Merged
merged 2 commits into from Mar 23, 2018
Merged

Updated jsonrpc to include latest backports (beta) #8181

merged 2 commits into from Mar 23, 2018

Conversation

kirushik
Copy link
Collaborator

No description provided.

@kirushik kirushik added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Mar 21, 2018
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 21, 2018
@kirushik kirushik removed the request for review from debris March 21, 2018 18:21
@debris debris added the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Mar 22, 2018
@debris
Copy link
Collaborator

debris commented Mar 22, 2018

@paritytech/ci it looks like we have a problem with #6507 again

@5chdn 5chdn added this to the Patch milestone Mar 22, 2018
@twittner
Update dependencies.
e7c254e 
- `jsonrpc` PR #244 required `hyper >= 0.11.20` which in turn required
updating `tokio-core`, `mio` and `iovec`.

- `jsonrpc` PR #246 required updating `https://github.com/tomusdrw/ws-rs`.
@twittner twittner mentioned this pull request Mar 23, 2018
Merged
@tomusdrw tomusdrw removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Mar 23, 2018
@tomusdrw tomusdrw merged commit 5acdd09 into beta Mar 23, 2018
@tomusdrw tomusdrw deleted the kirushik/update_jsonrpc_1_10 branch March 23, 2018 13:32
@twittner
Copy link
Contributor

twittner commented Mar 23, 2018 •
edited

@tomusdrw: I meant to make another push to update hyper to 0.11.24 (local compilation always takes a long time on my machine). This way the same hyper version would be used on all three branches. Do you want me to open another PR for that?

Edit: #8203

@peterbitfly peterbitfly mentioned this pull request Apr 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees

@twittner twittner

Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kirushik @debris @twittner @andresilva @tomusdrw @5chdn