This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Updated jsonrpc to include latest backports (1.9) #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirushik
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Mar 21, 2018
tomusdrw
added
A8-looksgood 🦄
andresilva
approved these changes
Mar 21, 2018
|
@paritytech/ci it looks like we have a problem with #6507 again |
debris
added
the
A4-awaitingci 🤖
|
But this error looks actually like there are multiple versions of Compiling jsonrpc-http-server v8.0.0 (https://github.com/paritytech/jsonrpc.git?branch=parity-1.9#e23a96cb)Update: $ cargo tree | grep parity-1.9 |
|
@niklasad1: If I am not mistaken, there are actually some dependency updates missing, e.g. hyper version >= 0.11.20. I am in the process of getting those updates in. Cf. #8180, #8181. |
- `jsonrpc` PR #244 required `hyper >= 0.11.20` which in turn required updating `tokio-core`, `mio` and `iovec`. - `jsonrpc` PR #246 required updating `https://github.com/tomusdrw/ws-rs`.
5chdn
removed
the
A4-awaitingci 🤖
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.